Refactor _validateSignature to allow Smart Wallets to sign for other Smart Wallets #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsoncusack
force-pushed
the
wilson/update-validate-signature
branch
from
f432fd0 to
3e2eccb
Compare
wilsoncusack
commented
Mar 5, 2024
| @@ -342,7 +319,7 @@ contract CoinbaseSmartWallet is MultiOwnable, UUPSUpgradeable, Receiver, ERC1271 | |||
| }); | |||
| } | |||
|
|
|||
| revert InvalidSignatureLength(sigWrapper.signatureData.length); | |||
| revert InvalidOwnerBytesLength(ownerBytes); | |||
There was a problem hiding this comment.
Maybe we could rename this more clearly? InvalidOwnerIndex? NoOwnerAtIndex?
xenoliss
approved these changes
Mar 7, 2024
|
Review Error for xenoliss @ 2024-03-07 12:06:25 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While discussing ERC-1271 with @xenoliss, we realized that there is currently no way for Smart Wallet to sign via ERC-1271 for another Smart Wallet. To fix this, we make _validateSignature primarily switch on the ownerBytes length, rather than the signature length, which cleans up the code and allows us to remove a couple errors entirely.