Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recordWithBrandedKeys should not be Partial #3918

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlexErrant
Copy link

@AlexErrant AlexErrant commented Dec 19, 2024

I am attempting to fix a regression. Here's a timeline:

  1. This PR describes an issue and is merged. Note that it primarily adds
  : K extends BRAND<string | number | symbol>
  ? Record<K, V>
  1. For reasons that are unclear to me this commit reverses the order of the above and uses [] syntax, causing a regression:
  : [BRAND<string | number | symbol>] extends [K]
  ? Record<K, V>
  1. My PR switches the order back to 1, keeps the [] syntax, and adds a test to prevent regressions:
  : [K] extends [BRAND<string | number | symbol>]
  ? Record<K, V>

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for guileless-rolypoly-866f8a ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fb936ed
🔍 Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/6764696db033910008bd4b25
😎 Deploy Preview https://deploy-preview-3918--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant