[tests] Add more matrix multiply tests #594
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more tests for matrix multiply.
And utility functions so additional tests for
multiply_v3_matrix3x3
will be easy to add.The new tests are skipped, because they are provisional, and I just want to highlight them.
The expected results are still visible in the HTML runner version of the tests.
If these tests seem reasonable for generic matrix multiplication, I'd be happy to make minimal changes to
multiplyMatrices
that would pass these tests in a future pull request.I have some broader questions around how matrix multiplication should work for
color.js
, but I started a discussion thread to have that broader conversation.