Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Add more matrix multiply tests #594

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

epsilonError
Copy link
Contributor

Added more tests for matrix multiply.
And utility functions so additional tests for multiply_v3_matrix3x3 will be easy to add.

The new tests are skipped, because they are provisional, and I just want to highlight them.
The expected results are still visible in the HTML runner version of the tests.

If these tests seem reasonable for generic matrix multiplication, I'd be happy to make minimal changes to multiplyMatrices that would pass these tests in a future pull request.

I have some broader questions around how matrix multiplication should work for color.js, but I started a discussion thread to have that broader conversation.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for colorjs ready!

Name Link
🔨 Latest commit 38e53b9
🔍 Latest deploy log https://app.netlify.com/sites/colorjs/deploys/66da61f0c7b2730008cfa862
😎 Deploy Preview https://deploy-preview-594--colorjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@epsilonError
Copy link
Contributor Author

I'll be adding a comment about my understanding of 'row-major ordered & pre-multiplication' vs 'column-major ordered & post-multiplication' to the broader discussion thread in the next few days.

@LeaVerou LeaVerou requested a review from lloydk December 26, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant