-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cwl-input-schema implementation #288
cwl-input-schema implementation #288
Conversation
86b9907
to
d8376bf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
+ Coverage 33.32% 33.67% +0.34%
==========================================
Files 29 30 +1
Lines 34864 35134 +270
Branches 9396 9467 +71
==========================================
+ Hits 11619 11831 +212
- Misses 20611 20656 +45
- Partials 2634 2647 +13 ☔ View full report in Codecov by Sentry. |
b4b829a
to
6294b44
Compare
@mr-c, @suecharo this is passing all tests (finally! - had a few issues where Note, currently failing as I repushed some documentation notes and the codecov token limit has been exceeded - will retrigger this in an hour. Shown here I've provided a script to run the json schema generation against all tools in all conformance tests and then compare the inputs using jsonschema-validate. |
This pull request has been mentioned on Common Workflow Language Discourse. There might be relevant details there: https://cwl.discourse.group/t/creating-config-json-file-from-a-record/172/4 |
7b2655c
to
1d65704
Compare
This pull request has been mentioned on Common Workflow Language Discourse. There might be relevant details there: https://cwl.discourse.group/t/json-schemas-for-validating-your-cwl-code-and-cwl-code-inputs/896/2 |
1ba1d6e
to
60fc130
Compare
* Use default definitions * Collect slim definition schema * Use Any as having any properties * Add passing and expected failing tests * Use type objects to generate schemas * Recurse through record schema objects Remove unused imports Fix test input urls Conformance tests should be their own header in input schema gen readme Also move part headers to secondary header and added toc Re-trigger CICD github actions testing
* removed duplicate type entries in parser, * fixed test function docs
60fc130
to
7564a3b
Compare
@mr-c tests are fixed, can we merge this please? |
Extension of #282
Related issues #273
Usage example
Details
Complex usage example
Gives
TODO