Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make empty stream behavior of splitSepBySeq_ similar to splitSepBy_ #2912

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make empty stream behavior of splitSepBySeq_ similar to splitSepBy_ #2912

wants to merge 2 commits into from

Conversation

adithyaov
Copy link
Member

@adithyaov adithyaov commented Dec 20, 2024 •
edited
Loading

  • Check the benchmarks

harendra-kumar
harendra-kumar reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@harendra-kumar harendra-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add some doctests in splitSepBySeq_ and splitEndBySeq similar to splitSepBy_ ? Also enable the doctests in splitBeginBy_.

@adithyaov
Copy link
Member Author

adithyaov commented Jan 2, 2025 •
edited
Loading

Also enable the doctests in splitBeginBy_.

splitBeginBy is undefined.

@adithyaov adithyaov force-pushed the split-fix branch 2 times, most recently from 13f8f72 to be62b4f Compare January 2, 2025 10:18
@adithyaov adithyaov linked an issue Jan 2, 2025 that may be closed by this pull request
Fix the empty stream behavior of splitSepBySeq_ #2847
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harendra-kumar harendra-kumar harendra-kumar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the empty stream behavior of splitSepBySeq_
2 participants
@adithyaov @harendra-kumar