-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pin for spdlog #6677
base: main
Are you sure you want to change the base?
Update pin for spdlog #6677
Conversation
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/spdlog and so here I am doing that. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
We should make some effort to wrap up the migrations for 1.13 and/or 1.14 before starting this IMO |
I'm not sure we should wait too long, many seem to be slow to update package caught up in the fmt 10 migration. |
we should likely close the other migrations when we merge this one. |
I'm not talking about waiting for the feedstock maintainers, I'm talking about proactively fixing the open PRs, or at least giving it a real shot before declaring all these feedstocks |
i get it. i've made attempts on and off but i'm not really an fmt10 expert... |
From my experience, fmt is very stable, the only "problem" is that it gets stricter over time, as more and more classes of bugs get diagnosed at compile time I agree that there's not much point in trying to build something for fmt 10 (which is on its way out, but would benefit from a similar clean-up to finish the fmt 11 migration). Ideally we should lift everything to fmt 11 and spdlog 1.14+ |
I mean i would love help finishing off the 1.14 migrations as they are now.. conda-forge/spiceql-feedstock#13 seems like an "easy" candidate to help with and maybe could teach me how to deal with fmt. |
This PR has been triggered in an effort to update the pin for spdlog. The current pinned version is 1.12, the latest available version is 1.15 and the max pin pattern is x.x. This migration will impact 41 feedstocks.
Checklist:
**Please note that if you close this PR we presume that the new pin has been rejected.
@conda-forge-admin please ping spdlog
This PR was generated by https://github.com/regro/cf-scripts/actions/runs/11760107321 - please use this URL for debugging.