-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert recipe (on hold) #978
base: main
Are you sure you want to change the base?
Conversation
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/recipe.yaml: This is a rattler-build recipe and not yet lintable. We are working on it! |
c444194
to
9c49f10
Compare
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally. This message was generated by GitHub actions workflow run https://github.com/conda-forge/gdal-feedstock/actions/runs/10639353086. |
hum conda-smithy doesn't seem happy with the removal of recipe/meta.yaml. I might have missed something in the blog post |
pushed a suspected change needed @conda-forge-admin please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally. This message was generated by GitHub actions workflow run https://github.com/conda-forge/gdal-feedstock/actions/runs/10641099586. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally. This message was generated by GitHub actions workflow run https://github.com/conda-forge/gdal-feedstock/actions/runs/10641163183. |
I got things a bit further along, but now am unsure what is needed to be done.
|
It sounds like we no longer need the redundant requirements at the top of the recipe.yaml. That's a nice change! |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally. This message was generated by GitHub actions workflow run https://github.com/conda-forge/gdal-feedstock/actions/runs/10643835380. |
- package: | ||
name: libgdal-core | ||
- package: | ||
name: libgdal-arrow-parquet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like something got messed up in the automatic parsing here?
This seems like it's going to be a slog. There are a lot of changes required to get this to render. For example,
needs to become:
in a bunch of places. The
but I couldn't figure out a way to move this to |
Remove root tests
It seems like we might want to hold off on this until some simpler recipes can point the way. This is an unusually complex feedstock and probably a really good test of the robustness of rattler-build but maybe not a good choice for early adoption. Also, see: |
Thanks both for working on this. Indeed, GDAL will be a good test case and we are more than happy to tackle it, but we should probably indeed follow @xylar's suggestion and tackle a few easier feedstocks first :) |
Cf https://prefix.dev/blog/rattler_build_on_conda_forge
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)-->