Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds conda build commands to pre_command plugin hook #29

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

travishathaway
Copy link
Collaborator

Fixes: #28

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79969cf) 97.97% compared to head (8e7ec88) 97.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   97.97%   97.98%           
=======================================
  Files          14       14           
  Lines         346      347    +1     
=======================================
+ Hits          339      340    +1     
  Misses          7        7           
Flag Coverage Δ
3.11 97.98% <100.00%> (+<0.01%) ⬆️
3.8 97.94% <100.00%> (+<0.01%) ⬆️
Linux 97.98% <100.00%> (+<0.01%) ⬆️
Windows 98.20% <100.00%> (+<0.01%) ⬆️
macOS 97.98% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@travishathaway travishathaway changed the title Adds conda build commands to those that are run on initialization Adds conda build commands to pre_command plugin hook Nov 27, 2023
@jaimergp
Copy link
Member

Do you need the subcommands to be sorted in a consistent way? sets won't maintain order and that has bitten me in the past.

@travishathaway
Copy link
Collaborator Author

@jaimergp,

No they don't. We just use them to run simple command in run_for_commands checks. More context:

https://github.com/conda/conda/blob/ded030a4791e652544f430e67f7362df4e0d6f72/conda/plugins/manager.py#L277-L285

@travishathaway travishathaway merged commit 4bc16e4 into main Nov 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working with conda-build on Debian with "keyring.alt" package with prefix.dev channels
2 participants