-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip-ci] TMT: run system tests on Fedora #24369
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
af89e2d
to
fbd02d2
Compare
A friendly reminder that this PR had no activity for 30 days. |
fbd02d2
to
ab31b4b
Compare
1276d46
to
002ca1c
Compare
Ephemeral COPR build failed. @containers/packit-build please check. |
5df7e93
to
a2a9383
Compare
a2a9383
to
ff774a1
Compare
ff774a1
to
c92c69f
Compare
@@ -187,7 +191,9 @@ when `%{_bindir}/%{name}sh` is set as a login shell or set as os.Args[0]. | |||
Summary: Metapackage for setting up %{name} machine | |||
Requires: %{name} = %{epoch}:%{version}-%{release} | |||
Requires: gvisor-tap-vsock | |||
%if %{defined qemu} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps you want qemu-kvm
? Publishing podman-machine in RHEL without QEMU otherwise feels rather moot?
2137e28
to
5322e01
Compare
@@ -187,7 +191,11 @@ when `%{_bindir}/%{name}sh` is set as a login shell or set as os.Args[0]. | |||
Summary: Metapackage for setting up %{name} machine | |||
Requires: %{name} = %{epoch}:%{version}-%{release} | |||
Requires: gvisor-tap-vsock | |||
%if %{defined qemu} | |||
Requires: qemu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that "qemu" is a really awkward dependency - it pulls in tons of emulators, spice-server, GTK, vte291 etc. -- all stuff that you really don't want on servers. qemu-system-x86-core
or qemu-kvm-core
exist everywhere and aren't so heavyweight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not use emulation, AFAICT we call qemu-system-x86_64 on x86_64 and qemu-system-aarch64 on aarch64.
Then we also need qemu-img
to resize the disk so whatever proves what we need should be fine.
$ rpm -q --whatprovides /usr/bin/qemu-img
qemu-img-8.2.8-2.fc40.x86_64
$ rpm -q --whatprovides /usr/bin/qemu-system-x86_64
qemu-system-x86-core-8.2.8-2.fc40.x86_64
$ rpm -q --whatprovides /usr/bin/qemu-system-aarch64
qemu-system-aarch64-core-8.2.8-2.fc40.x86_64
586f5bc
to
d669b9f
Compare
c60c626
to
30faf43
Compare
The default `gobuild` macro on CentOS Stream 9 now includes support for `BUILDTAGS`. CentOS Stream envs now also define `_user_tmpfilesdir` macro by default. Both these definitions are no longer needed here. Signed-off-by: Lokesh Mandvekar <[email protected]>
QEMU is available only on Fedora. RHEL and CentOS Stream can use qemu-kvm instead. Signed-off-by: Lokesh Mandvekar <[email protected]>
88703ed
to
4ca7502
Compare
/packit test |
b3dfdaf
to
6924c8a
Compare
This commit introduces TMT test jobs triggered via packit to run system tests on testing-farm infrastructure. Tests are run for all active Fedora and CentOS Stream environments for aarch64 and x86_64. The same test plan will be reused by Fedora for bodhi, zuul and fedora-ci gating tests. Packit will handle syncing of test plan and sources from upstream to downstream. Jobs will be selectively triggered for `main` v/s release branches based on the `release` PR label. The GHA for labeling PRs has also been updated in this commit. Test jobs on the main branch will include builds from the `rhcontainerbot/podman-next` copr while tests on release branches will only include official distro packages. Signed-off-by: Lokesh Mandvekar <[email protected]>
6924c8a
to
a4e73e7
Compare
/packit test |
This commit introduces TMT test jobs triggered via packit to run system
tests on testing-farm infrastructure. Tests are run for all active
Fedora environments for aarch64 and x86_64. The same
test plan will be reused by Fedora for bodhi, zuul and fedora-ci gating
tests. Packit will handle syncing of test plan and sources from upstream
to downstream.
Jobs will be selectively triggered for
main
v/s release branches basedon the
release
PR label. The GHA for labeling PRs has also beenupdated in this commit.
Test jobs on the main branch will include builds from the
rhcontainerbot/podman-next
copr while tests on release branches willonly include official distro packages.
Does this PR introduce a user-facing change?