Merge pull request #340 from conveyal/fix-stop-times-rounding

Remove rounding to 2 decimals in stop_times.shape_dist_traveled
conveyal · Feb 3, 2022 · f840040 · f840040
2 parents 4a8393b + 6f20ed6
commit f840040
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/main/java/com/conveyal/gtfs/loader/Table.java b/src/main/java/com/conveyal/gtfs/loader/Table.java
@@ -348,7 +348,7 @@ public Table (String name, Class<? extends Entity> entityClass, Requirement requ
             new ShortField("drop_off_type", OPTIONAL, 3),
             new ShortField("continuous_pickup", OPTIONAL, 3),
             new ShortField("continuous_drop_off", OPTIONAL, 3),
-            new DoubleField("shape_dist_traveled", OPTIONAL, 0, Double.POSITIVE_INFINITY, 2),
+            new DoubleField("shape_dist_traveled", OPTIONAL, 0, Double.POSITIVE_INFINITY, -1),
             new ShortField("timepoint", OPTIONAL, 1),
             new IntegerField("fare_units_traveled", EXTENSION) // OpenOV NL extension
     ).withParentTable(TRIPS);

diff --git a/src/test/java/com/conveyal/gtfs/GTFSTest.java b/src/test/java/com/conveyal/gtfs/GTFSTest.java
@@ -278,6 +278,13 @@ public void canLoadAndExportSimpleAgencyWithOnlyCalendarDates() {
                     new RecordExpectation("shape_dist_traveled", 0.0, 0.01)
                 }
             ),
+            // Check that the shape_dist_traveled values in stop_times are not rounded.
+            new PersistenceExpectation(
+                "stop_times",
+                new RecordExpectation[]{
+                    new RecordExpectation("shape_dist_traveled", 341.4491961, 0.00001)
+                }
+            ),
             new PersistenceExpectation(
                 "trips",
                 new RecordExpectation[]{