Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist patterns #394

Merged
merged 13 commits into from
Nov 7, 2023
Merged

Persist patterns #394

merged 13 commits into from
Nov 7, 2023

Conversation

br648
Copy link
Collaborator

@br648 br648 commented Aug 24, 2023 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Refactor to persist pattern data on export and load on import. The PR also refectors pattern building by creating a new PatternBuilder class for this process with distinct methods instead of a series of tasks in PatternFinderValidator.

binh-dam-ibigroup
binh-dam-ibigroup reviewed Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are my first comments (I need to play some more):

src/test/java/com/conveyal/gtfs/GTFSTest.java Outdated Show resolved Hide resolved
src/main/java/com/conveyal/gtfs/PatternBuilder.java Outdated Show resolved Hide resolved
src/main/java/com/conveyal/gtfs/PatternBuilder.java Outdated Show resolved Hide resolved
src/main/java/com/conveyal/gtfs/loader/Table.java Outdated Show resolved Hide resolved
src/main/java/com/conveyal/gtfs/loader/Table.java Outdated Show resolved Hide resolved
binh-dam-ibigroup
binh-dam-ibigroup approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well! See a few tweaks.

src/main/java/com/conveyal/gtfs/loader/Table.java Outdated Show resolved Hide resolved
src/main/java/com/conveyal/gtfs/model/Pattern.java Outdated Show resolved Hide resolved
@br648 br648 assigned philip-cline and unassigned br648 Sep 6, 2023
philip-cline
philip-cline requested changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking rly good, just a couple of questions

src/main/java/com/conveyal/gtfs/validator/PatternFinderValidator.java Show resolved Hide resolved
src/main/java/com/conveyal/gtfs/PatternBuilder.java Outdated Show resolved Hide resolved
src/main/java/com/conveyal/gtfs/PatternBuilder.java Show resolved Hide resolved
src/main/java/com/conveyal/gtfs/loader/Table.java Show resolved Hide resolved
src/main/java/com/conveyal/gtfs/PatternBuilder.java Show resolved Hide resolved
@philip-cline philip-cline assigned br648 and unassigned philip-cline Oct 4, 2023
@br648 br648 assigned philip-cline and unassigned br648 Oct 5, 2023
This was referenced Oct 6, 2023
Merged
Merged
philip-cline
philip-cline approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, thanks again!

@philip-cline philip-cline assigned br648 and unassigned philip-cline Nov 6, 2023
@br648 br648 merged commit bde0936 into dev Nov 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philip-cline philip-cline philip-cline approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@br648 br648

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@br648 @binh-dam-ibigroup @philip-cline