Skip to content

Commit

Permalink
Unblock RNTester instacrashing due to SoLoader not being enabled
Browse files Browse the repository at this point in the history
Summary:
After the SoLoader 0.12.0 bump I've noticed RNTester is instacrashing due to us not having enabled it
explicitely in the Manifest:

Changelog:
[Internal] [Changed] - Unblock RNTester instacrashing due to SoLoader not being enabled

Reviewed By: cipolleschi

Differential Revision: D62580751
  • Loading branch information
cortinico authored and facebook-github-bot committed Sep 12, 2024
1 parent 6243a33 commit fc0930f
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
7 changes: 6 additions & 1 deletion packages/helloworld/android/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools">

<uses-permission android:name="android.permission.INTERNET" />

Expand All @@ -21,5 +22,9 @@
<category android:name="android.intent.category.LAUNCHER" />
</intent-filter>
</activity>
<meta-data
android:name="com.facebook.soloader.enabled"
android:value="true"
tools:replace="android:value" />
</application>
</manifest>
7 changes: 6 additions & 1 deletion packages/rn-tester/android/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools">

<uses-feature
android:name="android.software.leanback"
Expand Down Expand Up @@ -65,6 +66,10 @@
android:authorities="@string/blob_provider_authority"
android:exported="false"
/>
<meta-data
android:name="com.facebook.soloader.enabled"
android:value="true"
tools:replace="android:value" />
</application>
<queries>
<package android:name="com.facebook.katana" />
Expand Down

0 comments on commit fc0930f

Please sign in to comment.