Bump Apicurio Registry version to 2.4.2.Final #16
Conversation
|
Thank you for the contribution to the project. Means a lot! |
| @@ -88,18 +86,17 @@ class SchemaRegistryDownloadTaskSpecification extends AbstractFunctionalSpecific | |||
|
|
|||
| then: | |||
| result.task(":$SchemaRegistryDownloadTask.TASK_NAME").outcome == TaskOutcome.SUCCESS | |||
| assertArtifactExistsAndIsReadable(metadata.outputPath, "${metadata.name}.${artifactType.extension}") | |||
| assertArtifactExistsAndIsReadable(metadata.outputPath, "${metadata.name}.${artifactType}") | |||
There was a problem hiding this comment.
I agree with notion of making the artifact type more flexible, however we still need to deal with the file extensions properly.
When executing the download task , this would produce an output file name of e.g. Person.AVRO, which does not have the proper extension that corresponds to that format.
Perhaps we could be explicit about the extension by integrating it into the outputPath property of DownloadArtifact, and omit the outputFileName property?
There was a problem hiding this comment.
What you are proposing seems reasonable to me.
Since I'm not familiar with the project, would you mind taking over this work?
Feel free to close this PR and come up with an alternative one, PR to my fork or whatever fit the best for you 👍
There was a problem hiding this comment.
Sure, I'll PR to your fork to keep this one open. Thanks once again 👍
There was a problem hiding this comment.
hey @dmuharemagic is there any update on this change? Currently apicurio is still in a PoC phase at our client, but we could really use this fix so that we can use this gradle plugin as well. Otherwise we would have to create something similar ourselves
There was a problem hiding this comment.
it also looks like the initial issue I create at apicurio registry side has been closed now. Would it help for traceability to create a new one here?
Apicurio/apicurio-registry#3301 (comment)
There was a problem hiding this comment.
@FinKingma It appears that the API changes resulting from the pull request at Apicurio/apicurio-registry#2963 have a more significant impact than originally anticipated. The ArtifactType is now directly mapped to a simple String in the internal API, and unfortunately, the current version of the Java SDK does not provide a way to retrieve the list of registered artifact types (although it is possible through the REST API, I will need to integrate the call using a custom HTTP client). As a result, the task will require more time to complete. Upgrading the Apicurio version cannot be separated from these implicit API changes. I have two options: either submit a pull request to the Apicurio repository to include the necessary call in their Java SDK or refactor the underlying communication with the registry using a custom HTTP client instead of the Java SDK. Either way, it will prolong the release of a new version, and I apologize for the delay. I am fully committed to resolving this issue and will provide the required upgrade soon.
FYI: I will close this PR and open a new issue/PR which will serve as the new integration point, considering this is a larger change.
There was a problem hiding this comment.
@dmuharemagic ah bummer, but thanks for the headsup, could you link the new issue once it is created?
There was a problem hiding this comment.
submit a pull request to the Apicurio repository to include the necessary call in their Java SDK
Sorry for the late feedback! If you can open an issue in apicurio-registry for the endpoint that is needed I'll be happy to take it!
There was a problem hiding this comment.
@dmuharemagic Really sorry for the late feedback but this thread went into Spam 😥
I added the missing API to the Registry Client library, please let me know if there is anything left I can do to facilitate.
There was a problem hiding this comment.
@andreaTP Sorry, missed your reply last night. Thank you for opening the issue and the quick implementation, really simplifies things on my end. 🙂
@FinKingma Sure, I'll link the new issue.
There was a problem hiding this comment.
Additionally, we need to bump the plugin version located here to support a proper release. (https://github.com/croz-ltd/apicurio-registry-gradle-plugin/blob/main/plugin/gradle.properties).
First of all, thanks for this plugin!
Fix: Apicurio/apicurio-registry#3301
The significant changes are because
ArtifactTypeis now mapped to a simpleStringto allow for user-defined extensions (e.g. we got requests for BigQuery).