Merge pull request #47 from tanhongit/refactor-events

(#42) add conditions to check and exclude invalid chat ids

resources/events/pull_request_review/dismissed.php

@@ -0,0 +1,12 @@
+<?php
+/**
+ * @var $payload mixed
+ */
+
+$message = "👷‍♂️🛠️ <b>Dismissed Pull Request Review Comment</b> - <a href=\"{$payload->pull_request->html_url}\">{$payload->repository->full_name}#{$payload->pull_request->number}</a> by <a href=\"{$payload->review->user->html_url}\">@{$payload->review->user->login}</a>\n\n";
+
+$message .= "🛠 <b>{$payload->pull_request->title}</b> \n\n";
+
+$message .= "🔗 Link: <a href=\"{$payload->review->html_url}\">{$payload->review->html_url}</a>\n\n";
+
+echo $message;

resources/events/pull_request_review/submitted.php

@@ -0,0 +1,12 @@
+<?php
+/**
+ * @var $payload mixed
+ */
+
+$message = "👷‍♂️🛠️ <b>New Pull Request Review Comment</b> - <a href=\"{$payload->pull_request->html_url}\">{$payload->repository->full_name}#{$payload->pull_request->number}</a> by <a href=\"{$payload->review->user->html_url}\">@{$payload->review->user->login}</a>\n\n";
+
+$message .= "🛠 <b>{$payload->pull_request->title}</b> \n\n";
+
+$message .= "🔗 Link: <a href=\"{$payload->review->html_url}\">{$payload->review->html_url}</a>\n\n";
+
+echo $message;

src/Http/Actions/SendNotifyAction.php

@@ -55,6 +55,10 @@ public function __invoke(): void
         if (!is_null($this->request->server->get('HTTP_X_GITHUB_EVENT')) && empty($chatMessageId)) {
             $this->notificationService->setPayload($this->request);
             foreach ($this->chatIds as $chatId) {
+                if (empty($chatId)) {
+                    continue;
+                }
+
                 $this->notificationService->sendNotify($chatId);
             }
         }