el capitan dylib fix #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,4 +11,5 @@ LIB=$(pwd)/lib | |||
| export LD_LIBRARY_PATH=$LIB:$LD_LIBRARY_PATH | |||
| export DYLD_LIBRARY_PATH=$LIB:$DYLD_LIBRARY_PATH | |||
|
|
|||
| java -Xmx8g -jar $JAR $@ | |||
| echo $DYLD_LIBRARY_PATH | |||
There was a problem hiding this comment.
I don't believe so. I wouldn't merge this yet though since I don't know if
it breaks installation on Linux or older osx.
On May 18, 2016 6:31 AM, "Sam Blackshear" [email protected] wrote:
In hopper.sh #4 (comment)
:@@ -11,4 +11,5 @@ LIB=$(pwd)/lib
export LD_LIBRARY_PATH=$LIB:$LD_LIBRARY_PATH
export DYLD_LIBRARY_PATH=$LIB:$DYLD_LIBRARY_PATH-java -Xmx8g -jar
$JAR $ @
+echo $DYLD_LIBRARY_PATHIs this needed?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/cuplv/hopper/pull/4/files/97fa46c84f318315a1b757e7dd89d79729417909#r63693610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment variable DYLD_LIBRARY_PATH no longer has any effect on OSx El capitan. This patch makes it work. I suspect there is a better way to do this so suggestions are welcome.