Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: table filters #575

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: table filters #575

wants to merge 14 commits into from
+788 −195

Conversation

DanielSchiavini
Copy link
Contributor

@DanielSchiavini DanielSchiavini commented Jan 2, 2025 •
edited
Loading

  • implement new filters for the new llama table
    • minimum filter with slider
    • multiselect filter
    • ignored the market age as we do not have that data
  • add empty state to the table

@vercel Vercel
Copy link

vercel bot commented Jan 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
curve-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 0:11am
curve-dapp-crvusd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 0:11am
curve-dapp-dao ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 0:11am
curve-dapp-lend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 0:11am
curve-dapp-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 0:11am

@DanielSchiavini DanielSchiavini requested review from 0xAlunara and removed request for 0xAlunara January 2, 2025 13:28
Base automatically changed from feat/tanstack-table to main January 2, 2025 13:34
0xAlunara
0xAlunara requested changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@0xAlunara 0xAlunara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only did a quick review given you're still actively working on it

packages/curve-ui-kit/src/shared/icons/FilterIcon.tsx Outdated Show resolved Hide resolved
apps/loan/src/components/PageLlamaMarkets/LendingMarketsTable.tsx Outdated Show resolved Hide resolved
apps/loan/src/components/PageLlamaMarkets/LendingMarketsFilters.tsx Outdated Show resolved Hide resolved
apps/loan/src/components/PageLlamaMarkets/LendingMarketsTable.tsx Outdated Show resolved Hide resolved
apps/loan/src/components/PageLlamaMarkets/LendingMarketsFilters.tsx Outdated Show resolved Hide resolved
apps/loan/src/components/PageLlamaMarkets/cells/PoolTitleCell/PoolWarnings.tsx Show resolved Hide resolved
apps/loan/src/components/PageLlamaMarkets/cells/PoolTitleCell/PoolBadges.tsx Outdated Show resolved Hide resolved
packages/curve-ui-kit/src/shared/ui/DataTable/DataTable.tsx Outdated Show resolved Hide resolved
packages/curve-ui-kit/src/shared/icons/ChainIcon.tsx Show resolved Hide resolved
apps/loan/src/components/PageLlamaMarkets/filters/MultiSelectFilter.tsx Outdated Show resolved Hide resolved
@OnlyJousting
Copy link
Contributor

OnlyJousting commented Jan 6, 2025 •
edited
Loading

SCR-20250106-mysk

The filter selector blends with the table background, I believe the items in the list should get some additional padding left as well

@DanielSchiavini
fix: paper background color
8ba3c25 
popups and selects can lose their contrast otherwise
@DanielSchiavini DanielSchiavini mentioned this pull request Jan 6, 2025
Open
OnlyJousting
OnlyJousting previously approved these changes Jan 7, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OnlyJousting OnlyJousting OnlyJousting approved these changes

@0xAlunara 0xAlunara Awaiting requested review from 0xAlunara

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielSchiavini @OnlyJousting @0xAlunara