Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: interact with Gist timer on main #840

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Conversation

dfed
Copy link
Contributor

@dfed dfed commented Dec 4, 2024

Attempts to resolve #839

Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

  • Assign members of your team to review the pull request.
  • Wait for pull request status checks to complete. If there are problems, fix them until you see that all status checks are passing.
  • Wait until the pull request has been reviewed and approved by a teammate
  • After code reviews are approved and you determine this PR is ready to merge, select Squash and Merge button on this screen, leave the title and description to the default values, then merge the PR.

@mahmoud-elmorabea
Copy link
Contributor

Thanks for suggesting a fix! That's really appreciated.

We have added this to our TODO list to run some regressions to see if that fix could have any affects on the overall functionality.

We will get back to you soon!

@mads-frameo
Copy link

mads-frameo commented Dec 15, 2024

Just add to support for prioritising the fix, we are also seeing the same crash.

@Shahroz16 Shahroz16 changed the title Interact with Gist timer on main chore: interact with Gist timer on main Jan 1, 2025
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.78%. Comparing base (486e228) to head (ace0e2c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
+ Coverage   64.74%   64.78%   +0.04%     
==========================================
  Files         152      152              
  Lines        6248     6251       +3     
==========================================
+ Hits         4045     4050       +5     
+ Misses       2203     2201       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shahroz16 Shahroz16 changed the title chore: interact with Gist timer on main fix: interact with Gist timer on main Jan 6, 2025
@Shahroz16 Shahroz16 merged commit 93200a4 into customerio:main Jan 6, 2025
7 of 11 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 6, 2025
## [3.7.1](3.7.0...3.7.1) (2025-01-06)

### Bug Fixes

* interact with Gist timer on main ([#840](#840)) ([93200a4](93200a4))
@dfed dfed deleted the patch-1 branch January 6, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in Gist.invalidateTimer
4 participants