Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: test conda on min python version #6538

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

MetRonnie
Copy link
Member

Note

Min Python version for conda is 3.8, not 3.7, due to lack of protobuf build for 3.7. See conda-forge/cylc-flow-feedstock#93

Unfortunately we didn't spot this in #5828 because we were not testing on Python 3.7

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes or tests or docs
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added small infrastructure GH Actions, Codecov etc. labels Jan 6, 2025
@MetRonnie MetRonnie self-assigned this Jan 6, 2025

- name: check for activate scripts
shell : bash -el {0}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliver-sanders
Copy link
Member

There is a second workflow which should also have spotted this, it is tracked on the status page, but it isn't run on a schedule so there error wasn't detected.

https://github.com/cylc/cylc-doc/blob/master/.github/workflows/create-conda-envs.yml

@oliver-sanders oliver-sanders merged commit bb0b942 into cylc:8.3.x Jan 6, 2025
13 checks passed
@MetRonnie MetRonnie deleted the actions-conda branch January 6, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure GH Actions, Codecov etc. small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants