Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.fix over maxsize limit not delete file #139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

1.fix over maxsize limit not delete file #139

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fbd90c
1.fix over maxsize limit not delete file
May 8, 2017
9566c2d
1.fix over maxsize limit not delete file
May 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/src/main/java/com/danikula/videocache/file/Files.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ static List<File> getLruListFiles(File directory) {
static void setLastModifiedNow(File file) throws IOException {
if (file.exists()) {
long now = System.currentTimeMillis();
boolean modified = file.setLastModified(now); // on some devices (e.g. Nexus 5) doesn't work
boolean modified = file.setLastModified(now/1000*1000); // on some devices (e.g. Nexus 5) doesn't work
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alway throw new IOException。because in some android device file.setLastModified return false

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ta893115871 please explain you fix. Who and when does throw IOException? Why you divide now to 1000*1000?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can test when the cache file over maxsize limit

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it here and here and here. Can you point to real problem or better write test to proof that my implementation is wrong ?

if (!modified) {
modify(file);
//if (file.lastModified() < now) {
Expand Down