DAOS-16630 control: improve dmg pool exclude #15668
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoking “dmg pool exclude”, an administrator may not be aware of whether this will break the pool-wise RF or not. If this breaks the pool-wise RF, there may be data loss. Hence, we should perform the pool-wise RF check (i.e., the pw_rf check in pool_svc_update_map_internal) before changing the pool map.
On the other hand, the administrator may also want to exclude rank/targets even if there may be data loss. We should introduce a new, explicit option for the administrator to say that she’s aware of the danger and would like to bypass the pool-wise RF check.
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: