Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wangdi/master dfuse #15669

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Wangdi/master dfuse #15669

wants to merge 5 commits into from

Conversation

wangdi1
Copy link
Contributor

@wangdi1 wangdi1 commented Dec 28, 2024

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wangdi1
DAOS-16686 dfuse: Fix overlapping chunk reads
1e0ecd1 
From #15298

Handle concurrent read in the chunk_read code. Rather than assuming
each slot only gets requested once save the slot number as part of the
request and handle multiple requests.

This corrects the behaviour and avoids a crash when multiple readers read
the same file concurrently and improves the performance in this case.

Required-githooks: true

Signed-off-by: Ashley Pittman <[email protected]>
@wangdi1
DAOS-16686 dfuse: Detect matching reads to avoid network access
e5e8040 
From #15528

If a read matches a current outstanding read then simply
connect the two and when there's a reply from the network
then respond to both requests.

Ashley Pittman <[email protected]>
Required-githooks: true
@wangdi1
DAOS-15626 dfuse: Improve linear-read detection code
a84726d 
Fix a bug where linear read was not correctly saved to the directory.
Improve the NLT testing of pre_read to not just invoke it but to use
the statistics to verify correct operation.

Required-githooks: true

Signed-off-by: Ashley Pittman <[email protected]>
@wangdi1
DAOS-16686 dfuse: avoid duplicate RPC between readahead and read
f7911a5 
Add readahead RPC in the open read list earlier to make sure
the following read will not send duplicate RPC.

Required-githooks: true

Signed-off-by: Di Wang <[email protected]>
@wangdi1
DAOS-16686 dfuse: set time for new created entry
8354c05 
Set dcache update timer for initialize timer, otherwise
keep_cache flag will not be set for opendir, then concurrent
opendir might truncate the directory page cache unnecessary.

Set valid timer for inode entry created by readdirplus,
otherwise the inode might needs to be lookup again.

Required-githooks: true

Signed-off-by: Di Wang <[email protected]>
@wangdi1 wangdi1 requested review from a team as code owners December 28, 2024 18:34
@github-actions GitHub Actions
Copy link

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Wangdi/master

@wangdi1 wangdi1 requested review from johannlombardi and jolivier23 and removed request for a team December 28, 2024 18:34
@wangdi1
Copy link
Contributor Author

wangdi1 commented Dec 28, 2024

all dfuse fixes based on master branch

@wangdi1 wangdi1 requested a review from wiliamhuang December 28, 2024 18:35
@wangdi1
Copy link
Contributor Author

wangdi1 commented Dec 28, 2024 •
edited
Loading

These are all fixes from @ashleypittman, plus some fixes we need to avoid sending extra RPCs if there are multiple concurrent RPCs reading the same file.

The first 3 patches are from @ashleypittman may be landed through other PR.

@ashleypittman please take a look. Thanks.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15669/1/execution/node/1464/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannlombardi johannlombardi Awaiting requested review from johannlombardi

@jolivier23 jolivier23 Awaiting requested review from jolivier23

@wiliamhuang wiliamhuang Awaiting requested review from wiliamhuang

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangdi1 @daosbuild1