-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tox support #318
Tox support #318
Conversation
importing semver in setup caused an error bc it was being imported before requirements file could install it
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
=======================================
Coverage 85.65% 85.65%
=======================================
Files 6 6
Lines 767 767
Branches 159 159
=======================================
Hits 657 657
Misses 92 92
Partials 18 18 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address comments above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Adding support for tox to manage local virtual environments. This will make it easier to run tests against a matrix of python & spark versions locally, standardize venvs across local machines and facilitate CI by using simple tox commands