Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tox support #318

Merged
merged 26 commits into from
Apr 25, 2023
Merged

Tox support #318

merged 26 commits into from
Apr 25, 2023

Conversation

R7L208
Copy link
Contributor

@R7L208 R7L208 commented Apr 24, 2023

Adding support for tox to manage local virtual environments. This will make it easier to run tests against a matrix of python & spark versions locally, standardize venvs across local machines and facilitate CI by using simple tox commands

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #318 (a4d6629) into master (26fb674) will not change coverage.
The diff coverage is n/a.

❗ Current head a4d6629 differs from pull request most recent head 6093075. Consider uploading reports for the commit 6093075 to get more accurate results

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   85.65%   85.65%           
=======================================
  Files           6        6           
  Lines         767      767           
  Branches      159      159           
=======================================
  Hits          657      657           
  Misses         92       92           
  Partials       18       18           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comments above.

python/requirements.txt Show resolved Hide resolved
Copy link
Contributor

@tnixon tnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tnixon tnixon merged commit 44f2235 into master Apr 25, 2023
@tnixon tnixon deleted the tox-support branch April 25, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants