Get-DbaHelpIndex - Bad joins based on Index Name instead of Index ID when Indexes in same DB named the same #9447

[jianjunpei]

Type of Change

• Bug fix (non-breaking change, fixes Get-DbaHelpIndex - Bad joins based on Index Name instead of Index ID when Indexes in same DB named the same #9447 )
• New feature (non-breaking change, adds functionality, fixes # )
• Breaking change (affects multiple commands or functionality, fixes # )
• Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
• Adding code coverage to existing functionality
• Pester test is included
• If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
• Unit test is included
• Documentation
• Build system

Purpose

Fix #9447

Approach

Changed the sql code by adding a new where condition
Added a new unit test

Commands to test

.\tests\manual.pester.ps1 -Path .\tests\Get-DbaHelpIndex.Tests.ps1 -TestIntegration

The original function will fail the following new unit test.
Context Result is correct for tables having the indexes with the same names
[+] Table t1 has correct index key columns and included columns 7ms
[+] Table t2 has correct index key columns and included columns 12ms

Screenshots

Here is a simple reproducible test.
create a test database with tables having an index each with the same name.

create database test1;
go
use test1;
go
create table t1(c1 int,c2 int,c3 int,c4 int);
create nonclustered index idx_1 on t1(c1) include(c3);
create table t2(c1 int,c2 int,c3 int,c4 int);
create nonclustered index idx_1 on t2(c1,c2) include(c3,c4);
go

Run get-dbahelpindex to check.
For example:
get-dbahelpindex -sqlinstance 'localhost,14330' -database test1|out-gridview

The existing version returns the following result, which is wrong for both tables.

The proposed version returns the following result, which is correct.

Learning

[potatoqualitee]

Thank you for your PR and your patience!