Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update jedi to v0.19.2 and parso to v0.8.4 #1130

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

jgb
Copy link
Contributor

@jgb jgb commented Dec 27, 2024

No description provided.

@davidhalter
Copy link
Owner

Thanks. Unfortunately somebody needs to look at the tests CI. Somethin g seems wrong, but it might as well be test. I would have to investigate.

BTW: Ignore the coverage CI, it should probably just be removed, it has been defunctional for a long time.

@jgb
Copy link
Contributor Author

jgb commented Dec 27, 2024

Thanks. Unfortunately somebody needs to look at the tests CI. Somethin g seems wrong, but it might as well be test. I would have to investigate.

BTW: Ignore the coverage CI, it should probably just be removed, it has been defunctional for a long time.

I'm running the tests locally, it seems it's the jedi upgrade that causes the tests to fail, upgrading parso alone doesn't cause any harm.
I'll try to see if it's a real problem or just an adjustment of the test is needed.

Update: looked into the jedi commits between v0.19.1 and v0.19.2 I don't see anything obvious that could explain what happens here :(

@davidhalter
Copy link
Owner

I'll check. Thanks for looking!

The tests are sometimes a bit brittle here and react to non-problems, so don't worry.

@davidhalter davidhalter merged commit 4ad1f2f into davidhalter:master Dec 27, 2024
1 of 3 checks passed
@davidhalter
Copy link
Owner

I fixed a few things around CI and basically just removed test parts that did not make sense: #1131

Thanks for your PR again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants