Make PV system optional #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #399.
The overall goal is to improve the experience for new users and make EMHASS easier to setup with no need to retrieve any data at all from HA or any other data source.
So in #399 a new load forecast method is proposed and based on historical typical household power consumption.
In this PR we want to make the PV system optional and set it to False by default, so that the minimal working configuration is just two deferrable loads (the ones already defined in the defaults json).
@GeoDerp, I will certainly need your help on this one. I've made the initial modifications needed to make the PV system optional. The approach is to keep the core code as it is and if there is no PV system then we just provide an all zeroes DataFrame
P_PV_forecastto the optimization code. But we now need to deal with the frontend part. We need to do the same treatment as with the battery and theset_use_batteryparameter. I've for now created a new parameterset_use_pv, but need to setup the frontend part for the webui and the correct treatment of this new parameter. Could you help with this when you have the time? Thanks ;-)