Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate test image from master #408

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

GeoDerp
Copy link
Contributor

@GeoDerp GeoDerp commented Dec 29, 2024

In theory, this additional github action will run every time a commit has been pushed into the master branch.
It will automatically generate a test tagged image, which could be used to test the latest changes on emhass-add-on / docker, prior to pushing a new release.

It also makes it easier for other users to check the changes and add comments before releasing.

@GeoDerp GeoDerp marked this pull request as ready for review December 29, 2024 04:53
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.24%. Comparing base (bcac4ce) to head (ff6807a).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
+ Coverage   66.04%   66.24%   +0.19%     
==========================================
  Files           8        8              
  Lines        2904     2900       -4     
==========================================
+ Hits         1918     1921       +3     
+ Misses        986      979       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidusb-geek
Copy link
Owner

And how can we launch this image?
Something like this?

docker run -it -p 5000:5000 --name emhass-test -v ./options.json:/data/options.json emhass/test

With some secrets defined in options.json to access the HA instance

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Dec 29, 2024

Should be the exact same as the original (pulling from the container registry). however you will be pulling from ghcr.io/davidusb-geek/emhass:test instead of ghcr.io/davidusb-geek/emhass:v0.11.4
you can also select the emhass-test version from emhass-add-on

Example:

# run Docker image, mounting config.json and secrets_emhass.yaml from host
docker run --rm -it --restart always  -p 5000:5000 --name emhass-container -v ./config.json:/share/config.json -v ./secrets_emhass.yaml:/app/secrets_emhass.yaml ghcr.io/davidusb-geek/emhass:test

just hold for two secs before merging however, I think I found a tag bug.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Dec 29, 2024

looks good now 👍

p.s. This is what it looks like on emhass-add-on
Screenshot From 2024-12-29 23-55-53

@davidusb-geek
Copy link
Owner

looks good now 👍

p.s. This is what it looks like on emhass-add-on Screenshot From 2024-12-29 23-55-53

Great, thanks for this!

@davidusb-geek davidusb-geek merged commit 99d08cc into davidusb-geek:master Dec 29, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants