-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloudevents] Switch to Debezium 2.0 #292
Open
vjuranek
wants to merge
3
commits into
debezium:main
Choose a base branch
from
vjuranek:2x_cloudevents
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 94 additions & 0 deletions
94
cloudevents/avro-data-extractor/src/main/docker/Dockerfile.jvm
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,94 @@ | ||
#### | ||
# This Dockerfile is used in order to build a container that runs the Quarkus application in JVM mode | ||
# | ||
# Before building the container image run: | ||
# | ||
# ./mvnw package | ||
# | ||
# Then, build the image with: | ||
# | ||
# docker build -f src/main/docker/Dockerfile.jvm -t quarkus/my-artifactId-jvm . | ||
# | ||
# Then run the container using: | ||
# | ||
# docker run -i --rm -p 8080:8080 quarkus/my-artifactId-jvm | ||
# | ||
# If you want to include the debug port into your docker image | ||
# you will have to expose the debug port (default 5005) like this : EXPOSE 8080 5005 | ||
# | ||
# Then run the container using : | ||
# | ||
# docker run -i --rm -p 8080:8080 quarkus/my-artifactId-jvm | ||
# | ||
# This image uses the `run-java.sh` script to run the application. | ||
# This scripts computes the command line to execute your Java application, and | ||
# includes memory/GC tuning. | ||
# You can configure the behavior using the following environment properties: | ||
# - JAVA_OPTS: JVM options passed to the `java` command (example: "-verbose:class") | ||
# - JAVA_OPTS_APPEND: User specified Java options to be appended to generated options | ||
# in JAVA_OPTS (example: "-Dsome.property=foo") | ||
# - JAVA_MAX_MEM_RATIO: Is used when no `-Xmx` option is given in JAVA_OPTS. This is | ||
# used to calculate a default maximal heap memory based on a containers restriction. | ||
# If used in a container without any memory constraints for the container then this | ||
# option has no effect. If there is a memory constraint then `-Xmx` is set to a ratio | ||
# of the container available memory as set here. The default is `50` which means 50% | ||
# of the available memory is used as an upper boundary. You can skip this mechanism by | ||
# setting this value to `0` in which case no `-Xmx` option is added. | ||
# - JAVA_INITIAL_MEM_RATIO: Is used when no `-Xms` option is given in JAVA_OPTS. This | ||
# is used to calculate a default initial heap memory based on the maximum heap memory. | ||
# If used in a container without any memory constraints for the container then this | ||
# option has no effect. If there is a memory constraint then `-Xms` is set to a ratio | ||
# of the `-Xmx` memory as set here. The default is `25` which means 25% of the `-Xmx` | ||
# is used as the initial heap size. You can skip this mechanism by setting this value | ||
# to `0` in which case no `-Xms` option is added (example: "25") | ||
# - JAVA_MAX_INITIAL_MEM: Is used when no `-Xms` option is given in JAVA_OPTS. | ||
# This is used to calculate the maximum value of the initial heap memory. If used in | ||
# a container without any memory constraints for the container then this option has | ||
# no effect. If there is a memory constraint then `-Xms` is limited to the value set | ||
# here. The default is 4096MB which means the calculated value of `-Xms` never will | ||
# be greater than 4096MB. The value of this variable is expressed in MB (example: "4096") | ||
# - JAVA_DIAGNOSTICS: Set this to get some diagnostics information to standard output | ||
# when things are happening. This option, if set to true, will set | ||
# `-XX:+UnlockDiagnosticVMOptions`. Disabled by default (example: "true"). | ||
# - JAVA_DEBUG: If set remote debugging will be switched on. Disabled by default (example: | ||
# true"). | ||
# - JAVA_DEBUG_PORT: Port used for remote debugging. Defaults to 5005 (example: "8787"). | ||
# - CONTAINER_CORE_LIMIT: A calculated core limit as described in | ||
# https://www.kernel.org/doc/Documentation/scheduler/sched-bwc.txt. (example: "2") | ||
# - CONTAINER_MAX_MEMORY: Memory limit given to the container (example: "1024"). | ||
# - GC_MIN_HEAP_FREE_RATIO: Minimum percentage of heap free after GC to avoid expansion. | ||
# (example: "20") | ||
# - GC_MAX_HEAP_FREE_RATIO: Maximum percentage of heap free after GC to avoid shrinking. | ||
# (example: "40") | ||
# - GC_TIME_RATIO: Specifies the ratio of the time spent outside the garbage collection. | ||
# (example: "4") | ||
# - GC_ADAPTIVE_SIZE_POLICY_WEIGHT: The weighting given to the current GC time versus | ||
# previous GC times. (example: "90") | ||
# - GC_METASPACE_SIZE: The initial metaspace size. (example: "20") | ||
# - GC_MAX_METASPACE_SIZE: The maximum metaspace size. (example: "100") | ||
# - GC_CONTAINER_OPTIONS: Specify Java GC to use. The value of this variable should | ||
# contain the necessary JRE command-line options to specify the required GC, which | ||
# will override the default of `-XX:+UseParallelGC` (example: -XX:+UseG1GC). | ||
# - HTTPS_PROXY: The location of the https proxy. (example: "[email protected]:8080") | ||
# - HTTP_PROXY: The location of the http proxy. (example: "[email protected]:8080") | ||
# - NO_PROXY: A comma separated lists of hosts, IP addresses or domains that can be | ||
# accessed directly. (example: "foo.example.com,bar.example.com") | ||
# | ||
### | ||
FROM registry.access.redhat.com/ubi8/openjdk-11:1.11 | ||
|
||
ENV LANGUAGE='en_US:en' | ||
|
||
|
||
# We make four distinct layers so if there are application changes the library layers can be re-used | ||
COPY --chown=185 target/quarkus-app/lib/ /deployments/lib/ | ||
COPY --chown=185 target/quarkus-app/*.jar /deployments/ | ||
COPY --chown=185 target/quarkus-app/app/ /deployments/app/ | ||
COPY --chown=185 target/quarkus-app/quarkus/ /deployments/quarkus/ | ||
|
||
EXPOSE 8079 | ||
USER 185 | ||
ENV AB_JOLOKIA_OFF="" | ||
ENV JAVA_OPTS="-Dquarkus.http.host=0.0.0.0 -Djava.util.logging.manager=org.jboss.logmanager.LogManager" | ||
ENV JAVA_APP_JAR="/deployments/quarkus-run.jar" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vjuranek Should not be README.md descriptions also updated because I suppose they are not aligned with the new
kafkacat
output?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's not aligned, but no idea what I should use a replacement. Removing schema option make the command to succeed (which schema it fails), output is not nice, but still good enough for user to verify data was written there. Output look like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vjuranek Are the schemas different? If yes can we replace the samples by quering the schemas from apicurio registry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpechane I'm not sure I follow. Which schemas? There is only one schema for all events. Mayeb there is misunderstanding as I forgot to remove schema from
kafkacat -b kafka:9092 -C -o beginning -q -s value=avro -r http://schema-registry:8080
in previous example. This is a mistake - it doesn't work either. Will remove it soon.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vjuranek ok, maybe it would make sense to rebuild the example a bit more. Apicurio provides the JSON converter that does not embed schema in message but stores it in registry in the same way as Avro does. How about changing the exmaple to use it instead of Avro? In that case it would be nicely presentable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpechane unfortunately this is not possible right now, as
CloudEventsConverter
works with schema registry only when avro is used and there are also other issues. I spent quite some time with it today with no reasonable results, so I'll try to prepare some reproducer and will raise an issue with Apicurio.For the record, I found out when one wants to use confluent based tools,
apis/ccompat/v6
should be used, i.e. the command should be something like this:With this, it still fails, but give at least somehow reasonable error:
So far no idea why
kafkcat
requests schema with ID0
(which is not present, but starting ID1
it is present), where it comes from and how to fix it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let's wait with this PR when the issue is resolved. BTW, I'd prefer not use
ccompat
API just to have different tooling used.WRT the schema there isapicurio.registry.id-handler
that should be set to theio.apicurio.registry.serde.Legacy4ByteIdHandler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
apicurio.registry.id-handler
doesn't seem to help, it just given me another exception. I also found out the issue mention above is already reported as apicurio-registry #2878