Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on to #181 Question clarification #185

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Add on to #181 Question clarification #185

merged 5 commits into from
Jun 26, 2024

Conversation

wendy-aw
Copy link
Contributor

  • Standardize Rishabh/clarify questions system prompt #181 changes across dialects
  • Also removed 'MoM will always be zero for the first month that appears in your answer.' because the queries were modified such that mom is NULL in the first row. Not zero.
  • Corrected a mini typo "Only included successful transactions" --> "Only include successful transactions"
  • Remove consumer_div. schema name for MySQL, SQLite, BigQuery
  • Clarify DDD question to return the average "Calculate the average DDD for each drug. Return the drug name and average DDD value." to match SQL.

Translation of the latest questions_gen to come in the next PR

Copy link
Member

@rishsriv rishsriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these changes, much appreciated!

@rishsriv rishsriv merged commit c40403b into main Jun 26, 2024
2 checks passed
@rishsriv rishsriv deleted the wendy/clarify_more branch June 26, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants