Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lint): remove manual AST field counter #27449

Merged
merged 3 commits into from
Dec 31, 2024
Merged

chore(lint): remove manual AST field counter #27449

merged 3 commits into from
Dec 31, 2024

Conversation

marvinhagemeister
Copy link
Contributor

Addresses the review feedback in #27416 .

  • Hoist the buffer max size variable to make it less confusing
  • Remove manual AST field counter in favour of an explicit "commit schema" step which writes the actual field count.

dsherret
dsherret approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@marvinhagemeister marvinhagemeister merged commit a844d96 into main Dec 31, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the lint_plugins_review branch December 31, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinhagemeister @dsherret