Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): Add missing inspector/promises #27491

Merged
merged 2 commits into from
Dec 31, 2024
Merged

fix(node): Add missing inspector/promises #27491

merged 2 commits into from
Dec 31, 2024
+14 −0

Conversation

ije
Copy link
Contributor

@ije ije commented Dec 29, 2024 •
edited
Loading

Add missing inspector/promises in node builtin module list, that causes types checking error

Screenshot 2024-12-29 at 20 05 30

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ije ije changed the title Update node builtin module list fix: Add missing inspector/promises Dec 29, 2024
@ije ije changed the title fix: Add missing inspector/promises fix(node): Add missing inspector/promises Dec 29, 2024
bartlomieju
bartlomieju approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bartlomieju bartlomieju merged commit 7b491a2 into denoland:main Dec 31, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ije @CLAassistant @bartlomieju