Skip to content

Commit

Permalink
Type the workflow input as a number, not a string (#11239)
Browse files Browse the repository at this point in the history
This input is a number, so although it's functioning fine currently as a string, by typing it properly as a number it removes a vector for string injection attacks if an attacker were to get escalated privileges on the repo.

To be clear: this doesn't close an active vulnerability, but is just wise defense-in-depth.

🎩 💁‍♂️ to the person who pointed this out, you know who you are. 😁
  • Loading branch information
jeffwidman authored Jan 6, 2025
1 parent fbaeb07 commit d3aa28c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/images-branch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on: # yamllint disable-line rule:truthy
inputs:
pr:
required: true
type: string
type: number
description: PR number

jobs:
Expand Down

0 comments on commit d3aa28c

Please sign in to comment.