address review feedback

dependabot · Jan 7, 2025 · ec7854f · ec7854f
1 parent 2808ab4
commit ec7854f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/RequirementConverter.cs b/nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/RequirementConverter.cs
@@ -7,10 +7,15 @@ public class RequirementConverter : JsonConverter<Requirement>
 {
     public override Requirement? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
     {
+        if (reader.TokenType != JsonTokenType.String)
+        {
+            throw new BadRequirementException($"Expected token type {nameof(JsonTokenType.String)}, but found {reader.TokenType}.");
+        }
+
         var text = reader.GetString();
         if (text is null)
         {
-            throw new ArgumentNullException(nameof(text));
+            throw new BadRequirementException("Unexpected null token.");
         }
 
         try

diff --git a/nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Clone/CloneWorker.cs b/nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Clone/CloneWorker.cs
@@ -31,6 +31,10 @@ public async Task<int> RunAsync(FileInfo jobFilePath, DirectoryInfo repoContents
         try
         {
             jobFile = RunWorker.Deserialize(jobFileContent);
+            if (jobFile is null)
+            {
+                parseError = new UnknownError(new Exception("Job file could not be deserialized"), _jobId);
+            }
         }
         catch (BadRequirementException ex)
         {