Metric collection for DotNet ecosystem and languages #11096
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachin-sandhu
force-pushed
the
ssandhu/nuget-package-manager
branch
22 times, most recently
from
f68ba6d to
d1fb58e
Compare
sachin-sandhu
force-pushed
the
ssandhu/nuget-package-manager
branch
3 times, most recently
from
20c5cbf to
529ddd2
Compare
amazimbe
reviewed
Dec 11, 2024
|
|
||
| sig { returns(Ecosystem::VersionManager) } | ||
| def package_manager | ||
| NugetPackageManager.new(nuget_version) |
There was a problem hiding this comment.
nuget_version could be nil so you probably need T.must(nuget_version)
amazimbe
reviewed
Dec 11, 2024
| end | ||
|
|
||
| sig { returns(T::Array[Dependabot::Dependency]) } | ||
| def content_json |
There was a problem hiding this comment.
Earlier, I run into issues when I changed the public interface of this class. Try moving this into the private section below.
amazimbe
reviewed
Dec 11, 2024
| # following block | ||
| version = Dependabot::SharedHelpers.run_shell_command("dotnet nuget --version").split("Command Line").last&.strip | ||
|
|
||
| it "does not raise error" do |
There was a problem hiding this comment.
To me, this looks like testing https://github.com/dependabot/dependabot-core/pull/11096/files#diff-81366b995ef0ba3d519c0c6bc42b165a1ed2bd2059cc6f51b8fecaa4d80b881fR138 and I feel that's where this test should move to. This class does not run the shell command.
sachin-sandhu
force-pushed
the
ssandhu/nuget-package-manager
branch
5 times, most recently
from
90deca9 to
53524bf
Compare
sachin-sandhu
force-pushed
the
ssandhu/nuget-package-manager
branch
from
53524bf to
1727bc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist