expand pattern to report missing files #11238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-report-missing-file
branch
from
a9c5cc8 to
1928eb0
Compare
sebasgomez238
approved these changes
Jan 6, 2025
brettfo
force-pushed
the
dev/brettfo/nuget-report-missing-file
branch
2 times, most recently
from
ea4ea4d to
a1d0ad4
Compare
ryanbrandenburg
approved these changes
Jan 6, 2025
sachin-sandhu
force-pushed
the
dev/brettfo/nuget-report-missing-file
branch
from
a1d0ad4 to
c84a37e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reporting missing files from MSBuild, we previously only supported one error message pattern:
but I've discovered that another pattern can occur:
This PR expands that pattern to report a missing file instead of getting classified as
unknown_error.