Handling markers with multiple condition joined with and/or logic. #11244
+52
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
If markers have multiple condition with and/or logic, the parser should be able to handle them correctly
Anything you want to highlight for special attention from reviewers?
Error reproduced in
https://github.com/dsp-testing/Python-Sample-Repo/pull/3/files
In current implementation
dependabot only checking
python_version >= '3.0'
instead of
python_version >= '3.0' and python_version <= '3.7'
fix provided to ensure that whole condition is being evaluated.
How will you know you've accomplished your goal?
RSpec added for
and
condition, Ensured it is not impacting other existing tests.and ran cli to ensure, not raising any PR for this scenario
Checklist