Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling markers with multiple condition joined with and/or logic. #11244

Merged

Conversation

thavaahariharangit
Copy link
Contributor

@thavaahariharangit thavaahariharangit commented Jan 7, 2025

What are you trying to accomplish?

If markers have multiple condition with and/or logic, the parser should be able to handle them correctly

Anything you want to highlight for special attention from reviewers?

Error reproduced in
https://github.com/dsp-testing/Python-Sample-Repo/pull/3/files

In current implementation

arrow==1.2.3; python_version >= '3.0' and python_version <= '3.7'

dependabot only checking python_version >= '3.0'
instead of python_version >= '3.0' and python_version <= '3.7'

fix provided to ensure that whole condition is being evaluated.

How will you know you've accomplished your goal?

RSpec added for and condition, Ensured it is not impacting other existing tests.
and ran cli to ensure, not raising any PR for this scenario

2025/01/07 12:57:33 INFO Starting update job for dsp-testing/Python-Sample-Repo
2025/01/07 12:57:33 INFO Checking all dependencies for version updates...
2025/01/07 12:57:33 INFO Checking if arrow 1.3.0 needs updating
2025/01/07 12:57:35 INFO Latest version is 1.3.0
2025/01/07 12:57:35 INFO No update needed for arrow 1.3.0

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@thavaahariharangit thavaahariharangit requested a review from a team as a code owner January 7, 2025 13:17
Copy link
Contributor

@sachin-sandhu sachin-sandhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thavaahariharangit thavaahariharangit merged commit 6948d5f into main Jan 7, 2025
62 checks passed
@thavaahariharangit thavaahariharangit deleted the harry/handling-markers-with-multiple-condition branch January 7, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants