Populate container list to allow filtering #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derailed
requested changes
Dec 27, 2024
There was a problem hiding this comment.
@dbaudracco Thank you for this PR. Nice catch! You are correct about adding the containers to the rule.
I think this could use some TLC in terms of drying up the code and testing the actual fix.
Also I think rs are missing from this line up.
| @@ -31,6 +32,12 @@ func NewCronJob(co *issues.Collector, db *db.DB) *CronJob { | |||
| } | |||
| } | |||
|
|
|||
| func CjSpecFor(fqn string, cj *batchv1.CronJob) rules.Spec { | |||
There was a problem hiding this comment.
I think this could be dry-ed up a bit i.e coSpecFor(string, metav1.ObjectMetaAccessor, v1.PodSpec).
Thus we would not need the same impl for any pod resources.
| @@ -59,3 +60,54 @@ func TestCronJobLint(t *testing.T) { | |||
| assert.Equal(t, `[POP-106] No resources requests/limits defined`, ii[5].Message) | |||
| assert.Equal(t, rules.WarnLevel, ii[5].Level) | |||
| } | |||
|
|
|||
| func TestCjSpecFor(t *testing.T) { | |||
There was a problem hiding this comment.
These tests really test the same call. Better would be to have tests that actually show the resolved fix i.e no spinach vs with spinach and show container codes exclusions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the exclusion of containers not working
Background
When using a spinach file like
I noticed that the relevant containers were not excluded:
After some debugging it appears that this is because the container list is not populated for the appropriate resources: this PR addresses the issue
Todo