fix Entrypoint to use Base image entrypoint #206
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cgruver The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| # Create symbolic links from /home/tooling/ -> /home/user/ | ||
| RUN stow . -t /home/user/ -d /home/tooling/ --no-folding | ||
|
|
There was a problem hiding this comment.
To be on the safer side, instead of removing the stow call, could we instead add .config in the stow ignore file here?
We have the stow call here to move certain /home/tooling folders (example) to /home/user.
The stow call might not be entirely necessary since the binaries installed under /home/tooling are being added to the PATH anyways. I'll have to investigate more to be sure whether the stow call can be removed.
There was a problem hiding this comment.
Do we need the stow call during build? I don't think that it does anything useful that isn't done when it runs in the entrypoint.sh
You'll see that exact same syntax is run in entrypoint.sh. When it runs there, it runs as the user not root.
There was a problem hiding this comment.
@dkwon17 I restored the stow command in the Dockerfile.
Signed-off-by: cgruver <[email protected]>
Signed-off-by: cgruver <[email protected]>
Signed-off-by: cgruver <[email protected]>
|
The build fails because the latest version of gopls (which was released yesterday) is incompatible with the latest available version of go available in the |
I will close this PR and resubmit with the latest from |
|
Superseded by #208 |
This PR is a fix for eclipse-che/che#23281
This PR also removes the run of
stowduring the build. Runningstowduring the image build creates/home/user/.configresulting in.configbeing owned by root..configbeing owned by root breaks podman v5+