Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next tag to tekton on-push #154

Merged

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Dec 16, 2024

Description of Changes

Summarize the changes you made as part of this pull request.

Adds next as an additional tag to the on-push tekton task.

Related Issue(s)

Link the GitHub/GitLab/JIRA issues that are related to this PR.

Part of devfile/api#1657

Acceptance Criteria

  • Unit Tests
  • E2E Tests
  • Documentation
    Update the sidebar if there is a new file added or an existing filename is changed

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

Signed-off-by: Michael Valdron <[email protected]>
@openshift-ci openshift-ci bot requested review from Jdubrick and thepetk December 16, 2024 19:01
@michael-valdron
Copy link
Member Author

Documentation
Update the sidebar if there is a new file added or an existing filename is changed

N/A

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member Author

/hold

Waiting on merging devfile/registry#529 first.

@michael-valdron
Copy link
Member Author

/unhold

@michael-valdron michael-valdron merged commit a309ca7 into devfile:main Dec 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants