Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update platform.rs to add FreeBSD support #385

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update platform.rs to add FreeBSD support #385

wants to merge 1 commit into from

Conversation

nkosi23
Copy link

@nkosi23 nkosi23 commented May 17, 2024

Adding FreeBSD support to platform.rs as it affects the build of a downstream project

@nkosi23 nkosi23 mentioned this pull request May 17, 2024
Open
@qwandor qwandor changed the base branch from master to dev May 17, 2024 09:12
@qwandor
Copy link
Collaborator

qwandor commented May 17, 2024

Thanks for the PR! You'll need to update the platform-specific dependencies in Cargo.toml too. It would also be good to have CI cover this if possible.

qdot
qdot requested changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@qdot qdot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as changes requested since we'd still need the Cargo.toml updates for platform. CI'ing this may be a challenge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qdot qdot qdot requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkosi23 @qwandor @qdot