Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access control #38

Conversation

GuentherJulian
Copy link
Contributor

@GuentherJulian GuentherJulian commented Dec 21, 2021

Closes #27

  • Added Smallrye JWT extension
  • Added role-based access control to the products service to secure the delete and post method
  • Adapted tests
  • Added documentation on how to deploy and configure keycloak

@GuentherJulian GuentherJulian self-assigned this Dec 21, 2021
@gitguardian
Copy link

gitguardian bot commented Dec 21, 2021

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
Secret Commit Filename Detected At
Generic High Entropy Secret acc7daf documentation/Keycloak/keycloak-realm.json 13:42 December 23rd, 2021 View secret
Generic High Entropy Secret acc7daf documentation/Keycloak/keycloak-realm.json 13:42 December 23rd, 2021 View secret
Generic Password acc7daf documentation/Keycloak/keycloak-realm.json 13:42 December 23rd, 2021 View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.

 

Our GitHub checks need improvements? Share your feedbacks

Copy link
Contributor

@rafaelvicariabarker rafaelvicariabarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some language suggestions

documentation/Keycloak/keycloak_authentication.asciidoc Outdated Show resolved Hide resolved
documentation/Keycloak/keycloak_authentication.asciidoc Outdated Show resolved Hide resolved
documentation/Keycloak/keycloak_authentication.asciidoc Outdated Show resolved Hide resolved
@maybeec
Copy link
Member

maybeec commented Dec 27, 2021

@GuentherJulian please check the credentials and please redo a clean PR. There are private keys here as part of the PR.
Not sure where they come from. But we have to be careful to not have any passwords and private keys in Git if possible although if they are just for "testing" as it will ring alarms at different ends as well and we'll get contacted to clarify such things as there is always the risk that we will oversee some critical occurrences for sure.

@maybeec maybeec closed this Dec 27, 2021

You can access Keycloak by navigating to http://localhost:8180/auth/ in your browser. Open the Administration console and log in with the default username "admin" and password "admin".

The first step is to create a new realm. A realm in Keycloak is used to manage a set of users with their credentials, groups and roles. Click on "Add realm" and then select the `keycloak-realm.json` file from the documentation/Keycloak folder of this repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention that you need to hover over the "Master" dropdown-menu to expose the "Add realm" button. It took me a minute :)

</dependency>
----

The extensions is already included in the dependencies. To enable it, set `quarkus.smallrye-jwt.enabled=true` in the `application.properties` file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extension is already included in the dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement access control concepts
3 participants