Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent init: Generate without secrets by default #29

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

discordianfish
Copy link
Member

This closes #28

Without --secret:

agent init /tmp/foo
caller=generator.go:60 level=info msg="can't find local diambra-arena version, using latest" err="exit status 1"
caller=generator.go:66 level=debug msg="using diambra-arena version" version=2.1.0rc1
🖥️  Creating requirements.txt
🖥️  Creating agent.py
🖥️  Creating README.md
🖥️  Creating Dockerfile
🖥️  Agent initialized in /tmp/foo

Then if run with --secret it will show the diff and prompt to overwrite. I don't think automatically changing the files is reliably enough to not make it more confusing. I would expect users to either just overwrite the files, or skip them and do the changes manually. A nicer diff output would be great, especially the char-by-char diffs is confusing. I've filled #19 for that already but thats something for later.

Here is the current output:
image

@alexpalms
Copy link
Member

@discordianfish This looks perfect! Let s merge it!

@discordianfish discordianfish merged commit 21bd2a5 into main Feb 4, 2023
@alexpalms alexpalms deleted the rework-agent-init branch February 25, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide basic and advanced usage of cli agent init command
2 participants