Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clarify indent format option api #2350

Merged

Conversation

simschla
Copy link
Contributor

As requested in #2311 here a little help for getting 7.0.0 out the door.

This resolves #794

@simschla simschla force-pushed the feature/clarify-indent-format-option-api branch 2 times, most recently from f510bb0 to de84697 Compare November 28, 2024 12:04
add deprecation warning for old api but keep supporting it

Refs: diffplug#794, diffplug#2311
- check for deprecation warnings but retained functionality of old api
- check functionality of new api

Refs: diffplug#794, diffplug#2311
@simschla simschla force-pushed the feature/clarify-indent-format-option-api branch from de84697 to 31aa59b Compare November 28, 2024 17:47
@nedtwigg
Copy link
Member

nedtwigg commented Dec 2, 2024

Amazing, thanks so much @simschla! This gives me a big boost to get the other issues resolved and finally exit this awful neverending beta period.

@nedtwigg nedtwigg merged commit 1804930 into diffplug:main Dec 8, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better names for indentWithSpaces and indentWithTabs
2 participants