-
Notifications
You must be signed in to change notification settings - Fork 240
fix: replace resolveString with verifyString #402
base: master
Are you sure you want to change the base?
Conversation
I just tested this PR and looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take out this.options
Shouldn't |
Once the PR has landed, this can be updated and fix two breaking changes together. |
I don't believe this PR should address both changes, no. I will update the typing though. |
Oh, yeah mb, I thought this was a PR for updating Commando for v13. |
There are a lot of things missing to support v13, This is getting kinda off-topic lets discuss on library-discussion if You want. |
can this be merged so we can use commando with the master version of discord.js |
This PR just Broke lmao, now You get |
It's still in there: https://github.com/discordjs/discord.js/blob/master/src/util/Util.js#L403 Are you sure you didn't change back to 12.5.3? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make Separate imports to escapeMarkdown, splitMessage, verifyString
const { // Imports } = require('discord.js').Util;
Yea I didn't changed back to 12, He Just forgot to add |
Replaces a reference to the now removed
Util.resolveString
withUtil.verifyString
Introduced by discordjs/discord.js#4880