Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Test with github actions #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: Test with github actions #10

wants to merge 1 commit into from

Conversation

orf
Copy link
Collaborator

@orf orf commented Sep 19, 2019

@orf
Copy link
Collaborator Author

orf commented Sep 19, 2019

@felixxm - I don't suppose we could get the credentials used to push to the Docker registry added here: https://github.com/django/django-docker-box/settings/secrets

I'd like to set up a small process to build the test image on a schedule and push, right now they are all rebuilding which takes a long time.

@orf orf force-pushed the github-actions branch 2 times, most recently from 90f0e2e to 62b1199 Compare September 19, 2019 22:51
Base automatically changed from master to main March 10, 2021 09:37
Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall I like the approach followed in this PR.

fail-fast: false
matrix:
python_version:
- 3.6
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can update the python versions here to 3.8+

python_version:
- 3.6
- 3.7
runs-on: ubuntu-latest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of ubuntu latest wouldn't it better to use ubuntu LTS like ubuntu 20.04 and in future 22.04 etc

PYTHON_VERSION: 3.6
- run: DJANGO_PATH=${GITHUB_WORKSPACE}/django docker-compose run chrome
env:
PYTHON_VERSION: 3.6
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.8+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants