-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Test with github actions #10
base: main
Are you sure you want to change the base?
Conversation
@felixxm - I don't suppose we could get the credentials used to push to the Docker registry added here: https://github.com/django/django-docker-box/settings/secrets I'd like to set up a small process to build the test image on a schedule and push, right now they are all rebuilding which takes a long time. |
90f0e2e
to
62b1199
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall I like the approach followed in this PR.
fail-fast: false | ||
matrix: | ||
python_version: | ||
- 3.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can update the python versions here to 3.8+
python_version: | ||
- 3.6 | ||
- 3.7 | ||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of ubuntu latest wouldn't it better to use ubuntu LTS like ubuntu 20.04 and in future 22.04 etc
PYTHON_VERSION: 3.6 | ||
- run: DJANGO_PATH=${GITHUB_WORKSPACE}/django docker-compose run chrome | ||
env: | ||
PYTHON_VERSION: 3.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.8+
https://github.community/t5/GitHub-Actions/Allow-nesting-matrix-includes/m-p/32240#M1058 - this would be super useful here