Added code to opDispatch to make a full example that can be copy, pas… #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted and run. I believe this will more clearly help users understand opDispatch. For clarity, I changed the incoming type to spell out 'Type'
ntrel
reviewed
Jul 3, 2023
|
BTW There are other examples such as here that don't declare |
Agreed, initially I thought 'Type' with 'Types' was a bit clearer, but the convention is purely 'T' Co-authored-by: Nick Treleaven <[email protected]>
Co-authored-by: Nick Treleaven <[email protected]>
My thoughts are for the call logger example it is something new enough enough that a beginner might want to copy & paste. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to opDispatch to make a full example that can be copy, pasted and run. I believe this will more clearly help users understand opDispatch. For clarity, I changed the incoming type to spell out 'Type'