-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: SCA upgrade #122
WIP: SCA upgrade #122
Conversation
@NorfairKing looks good, seems the |
@dmjio Yes, everything about this is not done. Is this really the only set of endpoints that needs to be finished? |
@NorfairKing seems like we need to facilitate this payment workflow |
We might also need |
We'll also need the new events then, because that's how you do the last part. |
My project also needs this functionality. Just let me know what I can help with! |
@emhoracek It would be great if you could help finish the pull request because I don't have much time. |
@dmjio It looks like |
To anyone reading this: I have no unpushed local work, please help out because I don't really have the time to complete this. |
@dmjio Could you have a look and tell me what else needs to be done for payment intents? |
@NorfairKing what's the status of this? Did you manage to build |
@sigrlami Yes, but I don't have the funds/time to finish this PR. I'm just using my own branch for the moment. |
What's missing for this PR? I need Sessions support, and I have some free time to try this week. |
@2piix Go for it. I won't have the resources to finish this PR. I thought I did something on the topic of sessions in this PR though. Have a look. |
, sessionClientReferenceId :: Maybe ClientReferenceId | ||
, sessionCustomerEmail :: Maybe CustomerEmail | ||
, sessionBillingAddressCollection :: Maybe TODO | ||
, sessionDisplayItems :: Maybe [TODO] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NorfairKing Do you remember where you got sessionDisplayItems
from? I can't see anything about display items in the API reference.
Position Dev managed to take this branch and add a few more types and endpoints and get our client set up for SCA - thanks @NorfairKing for getting this started. I'm going to try to finish the upgrade (currently still has a lot of |
Closing this.
|
@NorfairKing should we deprecate in favor of https://github.com/Haskell-OpenAPI-Code-Generator/Stripe-Haskell-Library ? |
I generate a custom I wouldn't necessarily say deprecate it, but this library is out-of-date for my use-case and I find it more sustainable to generate code instead. |
No description provided.