Adds support for css-variables to the react common components #6291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces hardcoded values in the PersonaBar main styles to use the dnn css-variables which allows matching branding. - The previous way to provide a PersonaBar theme still works, so if implementors want their own style to stay unchanged no matter what portal the admin UI is accessed from, that can still work by using actual values instead of the css variables. - This does not yet include the common components and the modules themselves, I'll do that in other PRs.
…/css/theme.css Co-authored-by: David Poindexter <[email protected]>
This adds support for css variables to the react common components. I needed the changes from dnnsoftware#6279 in order to be able to on this. So if it is merged before this one, it becomes easier to review. If not and this one is merged, then this one includes it.
david-poindexter
requested changes
Jan 4, 2025
There was a problem hiding this comment.
Fantastic (tedious I'm sure) work there @valadas - thank you! 🎉
Dnn.AdminExperience/ClientSide/Dnn.React.Common/src/CollapsibleRow/style.less
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/ClientSide/Dnn.React.Common/src/CollapsibleRow/style.less
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/ClientSide/Dnn.React.Common/src/DayPicker/style.less
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/ClientSide/Dnn.React.Common/src/SingleLineInputWithError/style.less
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/ClientSide/Dnn.React.Common/src/SingleLineInputWithError/style.less
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/ClientSide/Dnn.React.Common/src/SingleLineInputWithError/style.less
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/ClientSide/Dnn.React.Common/src/SingleLineInputWithError/style.less
Outdated
Show resolved
Hide resolved
…eRow/style.less Co-authored-by: David Poindexter <[email protected]>
…eRow/style.less Co-authored-by: David Poindexter <[email protected]>
…style.less Co-authored-by: David Poindexter <[email protected]>
…InputWithError/style.less Co-authored-by: David Poindexter <[email protected]>
…InputWithError/style.less Co-authored-by: David Poindexter <[email protected]>
…InputWithError/style.less Co-authored-by: David Poindexter <[email protected]>
…InputWithError/style.less Co-authored-by: David Poindexter <[email protected]>
|
Great catches @david-poindexter I just accepted all those suggestions |
mitchelsellers
approved these changes
Jan 5, 2025
david-poindexter
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for css variables to the react common components.
I needed the changes from #6279 in order to be able to on this. So if it is merged before this one, it becomes easier to review. If not and this one is merged, then this one includes it.
Out of the box styles:
Some ugly custom styles just to show it works:
