Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify timeout middleware ordering #31110

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Clarify timeout middleware ordering #31110

merged 1 commit into from
Nov 23, 2023

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Nov 22, 2023 •
edited by github-actions bot
Loading

Fixes dotnet/aspnetcore#52295

All three of these middleware can handle an exception and not re-throw it, the most specific middleware (timeouts) needs to be last so it can handle them first.

Internal previews

📄 File 🔗 Preview link
aspnetcore/fundamentals/middleware/index.md ASP.NET Core Middleware

@Tratcher Tratcher requested a review from tdykstra November 22, 2023 22:33
@tdykstra tdykstra merged commit fa854f7 into main Nov 23, 2023
2 checks passed
@tdykstra tdykstra deleted the tratcher/timeoutorder branch November 23, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The 499 status code may be returned when using Request timeouts and Exception Handler together
2 participants
@Tratcher @tdykstra