Do not call async_delete_issue() if there is no issue to delete in Sh…

…elly integration (home-assistant#120762) Co-authored-by: Maciej Bieniek <[email protected]>
dougiteixeira · Jun 28, 2024 · c029c53 · c029c53
1 parent f4224a0
commit c029c53
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/homeassistant/components/shelly/coordinator.py b/homeassistant/components/shelly/coordinator.py
@@ -377,12 +377,13 @@ def _async_handle_update(
                 eager_start=True,
             )
         elif update_type is BlockUpdateType.COAP_PERIODIC:
+            if self._push_update_failures >= MAX_PUSH_UPDATE_FAILURES:
+                ir.async_delete_issue(
+                    self.hass,
+                    DOMAIN,
+                    PUSH_UPDATE_ISSUE_ID.format(unique=self.mac),
+                )
             self._push_update_failures = 0
-            ir.async_delete_issue(
-                self.hass,
-                DOMAIN,
-                PUSH_UPDATE_ISSUE_ID.format(unique=self.mac),
-            )
         elif update_type is BlockUpdateType.COAP_REPLY:
             self._push_update_failures += 1
             if self._push_update_failures == MAX_PUSH_UPDATE_FAILURES: