Return default of false for _bpf_enabled() (#1355)

If the scap handle doesn't exist, return false from _bpf_enabled() methods.
draios · Apr 2, 2019 · c6bd3b1 · c6bd3b1
1 parent c9293a9
commit c6bd3b1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/userspace/libscap/scap.c b/userspace/libscap/scap.c
@@ -1973,6 +1973,8 @@ bool scap_get_bpf_enabled(scap_t *handle)
 	{
 		return handle->m_bpf;
 	}
+
+	return false;
 }
 
 int32_t scap_suppress_events_comm(scap_t *handle, const char *comm)

diff --git a/userspace/libsinsp/sinsp.cpp b/userspace/libsinsp/sinsp.cpp
@@ -2432,6 +2432,8 @@ bool sinsp::is_bpf_enabled()
 	{
 		return scap_get_bpf_enabled(m_h);
 	}
+
+	return false;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
-Original file line number
+Diff line change
@@ Expand Up / @@ -1973,6 +1973,8 @@ bool scap_get_bpf_enabled(scap_t *handle) @@
     	{
     		return handle->m_bpf;
     	}
+    	return false;
     }
     int32_t scap_suppress_events_comm(scap_t *handle, const char *comm)
@@ Expand Down @@